Conversation
Signed-off-by: Barry Xu <[email protected]> Co-authored-by: Chen Lihui <[email protected]>
|
Hello, just two comments:
|
|
Thanks for your comments.
Yes. I understand. These scrips (build_firmware.sh, etc) should not be modified. micro_ros_setup/scripts/build_firmware.sh Lines 72 to 76 in 720350f
I know you plan to remove official support to NuttX in micro-ROS Galactic. So foxy version also don't want to add any change for NuttX. Right ? |
|
Yes, you are right, And we will keep supporting NuttX on foxy, so feel free to include your port into this version. But in the future, only the new app will be used. |
Okay. Thank you.
Get it. |
README.md
Outdated
| | ST Nucleo H743ZI <sup>1</sup> | - | - | UART | | ||
| | ST Nucleo F746ZG <sup>1</sup> | - | UART | UART | | ||
| | ST Nucleo F767ZI <sup>1</sup> | - | UART | - | | ||
| | Spresense | WiFi | - | - | |
There was a problem hiding this comment.
Nit:
| | Spresense | WiFi | - | - | | |
| | Spresense | Network | - | - | |
config/nuttx/spresense/configure.sh
Outdated
| set -o pipefail | ||
|
|
||
|
|
||
| # spresense use own sdk to config |
There was a problem hiding this comment.
Nit:
| # spresense use own sdk to config | |
| # spresense uses own sdk to config |
| <name>firmware</name> | ||
| <version>0.0.1</version> | ||
| <description>This is a dummy package to supply firmware build dependencies for spresense.</description> | ||
| <maintainer email="[email protected]">Ingo Luetkebohle</maintainer> |
There was a problem hiding this comment.
| <maintainer email="[email protected].com">Ingo Luetkebohle</maintainer> | |
| <maintainer email="Barry.Xu@sony.com">Barry Xu</maintainer> | |
| <maintainer email="[email protected]">Tomoya Fujita</maintainer> |
There was a problem hiding this comment.
Thanks for your review comments. I have addressed them at 4184ad9.
Signed-off-by: Barry Xu <[email protected]>
No description provided.